Query room ignore case, mention text show contact name. #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
helloocc commented Jun 28, 2022
helloocc commented - query room ignore case
- coverage decrease will cause CI failed, now off.
wj-Mcat reviewed Jul 1, 2022
src/wechaty/user/room.py Outdated
| if not payload: | ||
| return False | ||
| if query == payload.id or query in payload.topic: | ||
| if query == payload.id or (query.lower() in payload.topic.lower()): |
Contributor Author
There was a problem hiding this comment.
hard to fix static check:)
wj-Mcat reviewed Jul 1, 2022
.github/workflows/pypi.yml Outdated
Comment on lines 29 to 30
| project: off | ||
| patch: off |
Collaborator
There was a problem hiding this comment.
Can you give more desc for this changes, so that I can easily understand what you have done ? and I notice that the latest version of coverage is V3, can you upgrade it ? If so, it will be more great for this contribution.
Contributor Author
There was a problem hiding this comment.
I notice that if coverage decrease, x will be show in commit. like this: 6940577 So, turn off is better.
However, I will not change it this patch.
wj-Mcat requested changes Jul 1, 2022
Collaborator
wj-Mcat left a comment
wj-Mcat left a comment There was a problem hiding this comment.
Your contribution is great, and there are some things need to be discussed.
helloocc force-pushed the master branch 2 times, most recently from 6979352 to abe1edd Compare helloocc changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.