liftM2 is not working with IO monads #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
liftM2 throws a type error when it's used with IO monads. This commit contains the test to highlight that.
Owner
| I see that there is an issue with similar blocks of code, this is linter issue, so I would like you add code comments that instrument linter that this is OK for those two methods to have the same signatures.
|
Contributor Author
| I realized now that liftM2 could simply call liftA2 behind the scenes. I've never understood why there are two functions doing almost the same thing. Then I discover that liftM2 is much older than liftA2 |
widmogrod approved these changes Jun 20, 2020
ilario-pierbattista deleted the ilario-pierbattista-liftm2-not-working-with-io branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi @widmogrod I've noticed that the implementation I proposed in #100 throws a type error with IO monads.
This PR consists in two commits.
Thanks