This repository was archived by the owner on Dec 12, 2025. It is now read-only.
Migrate tests from Jasmine 1.3.1 to Jasmine 2.3.4#369
Merged
nicksay merged 1 commit intoyoutube:masterfrom Sep 28, 2015
Merged
Conversation
src/client/nav/request_test.js Outdated
Member
There was a problem hiding this comment.
consider using "xit" to disable the test
Member
| LGTM |
- Upgrade bower package and adjust symlinks - Use new test runner for Jasmine 2 - Update assertion syntax throughout tests for new API - Update mock values throughout tests for new API - Update custom matchers for new API - Fix a couple tests for complex object equality round-tripping through JSON - Disable one test that is now failing; will be fixed in another change Closes youtube#364
nicksay force-pushed the upgrade-jasmine branch from bb617bd to 1050c30 Compare nicksay added a commit that referenced this pull request Sep 28, 2015
Migrate tests from Jasmine 1.3.1 to Jasmine 2.3.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364