Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Remove stream wrapper functionality#34

Open
mtymek wants to merge 1 commit intozendframework:developfrom
mtymek:remove_stream_wrapper
Open

Remove stream wrapper functionality#34
mtymek wants to merge 1 commit intozendframework:developfrom
mtymek:remove_stream_wrapper

Conversation

@mtymek
Copy link
Contributor

@mtymek mtymek commented Feb 8, 2016

Fixes #23.

@mtymek
Copy link
Contributor Author

mtymek commented Feb 8, 2016

Tests are failing, but it looks like compatibility issues with other ServiceManager v3.

@weierophinney weierophinney added this to the 3.0.0 milestone May 11, 2016
@sasezaki
Copy link
Contributor

As I said on #23,
Since PHP 5.4.0, <?= is always available.
Is this BC break ?
( situation when user uses extending \Zend\View\Stream ?)

@Ocramius
Copy link
Member

@sasezaki the reason this is labeled as BC break is removal of API (even if protected). The correct approach could be deprecation + removal of these method bodies, while the API survives till the next major release.

@sasezaki
Copy link
Contributor

@Ocramius thanks describe reason

@Ocramius
Copy link
Member

@sasezaki it's an API change, which means that any subclasses may be broken by the change (that's why we use private by default now)

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-view; a new issue has been opened at laminas/laminas-view#28.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-view. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-view to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-view.
  • In your clone of laminas/laminas-view, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4 participants