Exposing Whitelisted Protocols to User Settings #1401
Conversation
jonassorgenfrei changed the title jonassorgenfrei force-pushed the WhitelistedProtocols branch from bf9e06c to 6edcbb3 Compare 
| Thanks! Could you please update your commit message to match the commit style guidelines? |
| Do not close and reopen multiple pull requests for the same thing, even to fix the commit structure; you can always fix the commit structure by rebasing and force-pushing your existing branch. |
jonassorgenfrei force-pushed the WhitelistedProtocols branch from 6edcbb3 to 084620f Compare 
| I adjusted the commit message to match the style guide. |
| Is there anything left to do on this PR? |
jonassorgenfrei force-pushed the WhitelistedProtocols branch 2 times, most recently from 87f4cff to f56c2d0 Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from f56c2d0 to d270d56 Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from f21fa7d to dfe3839 Compare | @andersk @timabbott can you take a look if there's anything missing here that avoid a merge? |
| I think we'd need documentation for how users can decide which protocols they can safely add there. |
Totally makes sense, i'm just unsure where to document the setting.json 's new key. Could you point me to where i shall add the information then i'm happy to add it there too |
| A new file seems fine. I'd call it |
jonassorgenfrei force-pushed the WhitelistedProtocols branch from e333a68 to d1b0d88 Compare | Allright i added a customize-link-protocols.md to docs/howto :) |
jonassorgenfrei force-pushed the WhitelistedProtocols branch from 3158084 to d244c9c Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from bab7c2a to eeb0b1a Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from 5de33ef to bab7c2a Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from bab7c2a to 956fa35 Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from 956fa35 to bab7c2a Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from bab7c2a to aa21fe9 Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from 6efd4ac to ee73c58 Compare jonassorgenfrei force-pushed the WhitelistedProtocols branch from ee73c58 to d270d56 Compare 
Adding config option to set protocols in the config that are whitelisted to be opened directly. The behaviour is documented in docs\howto\customize-link-protocols.md.
| @timabbott could you may be take another look on the PR? Everything should be there now, would be cool if we can merge it in main, |
shubham-padia left a comment
shubham-padia left a comment There was a problem hiding this comment.
This is great work! Tested and it works fine. Requested some changes for comments.
| import {Html, html} from "./html.ts"; | ||
| import * as t from "./translation-util.ts"; | ||
| | ||
| /* Fetches the current protocolLaunchers from settings.json */ |
There was a problem hiding this comment.
protocolLaunchers doesn't seem like a noun. I don't think this comment is needed, since it is clear from using ConfigUtil.getConfigItem( that we are fetching from settings.json
| By default, the following protocols are whitelisted: | ||
| | ||
| ``` | ||
| http https mailto tel sip |
There was a problem hiding this comment.
Maybe we can separate this using a comma?
| | ||
| It is possible to customize the list of whitelisted protocols by editing the `settings.json` file located at: `userdata/Zulip/config/settings.json` | ||
| | ||
| To add or modify the list, the `whitelistedProtocols` key can be updated. For example: |
There was a problem hiding this comment.
To add or modify -> To modify
| | ||
| Links using these protocols are opened directly by the system. | ||
| | ||
| All other protocols are considered potentially unsafe and are therefore opened indirectly—through a local HTML file—in your default web browser. |
| Opened #1467 with the proposed changes while keeping the author same. |
6 participants
What's this PR do?
It exposes the whitelisted protocols list so users can add additional protocols that should not use the link wrapper.
Adresses Issue: #1284
You have tested this PR on: