about_popup: Terminal size added. #1542
Conversation
Swarnim114 force-pushed the main branch 2 times, most recently from 03845de to 2ce2242 Compare 
| Hello @Swarnim114, it seems like you have referenced #1536 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit: To learn how to write a great commit message, please refer to our guide. |
| ERROR: Label "Pr need review" does not exist and was thus not added to this pull request. |
| @zulipbot label "PR needs review" |
| @rsashank, I apologize for the confusion. This will be my final pull request for this issue. Thank you for your patience.This is the same code from before, |
| self.show_pop_up(NoticeView(self, text, width, "NOTICE"), "area:error") | ||
| | ||
| def show_about(self) -> None: | ||
| terminal_size = shutil.get_terminal_size() |
There was a problem hiding this comment.
You changed to using shutil here - was there as a specific reason for this?
There was a problem hiding this comment.
@Swarnim114 To confirm, this looks good, but I wasn't sure why you switched to this.
There was a problem hiding this comment.
@neiljp I thought it would be just simpler and give me no issues..
There was a problem hiding this comment.
os.get_terminal_size() works fine, no?
I tried to replicate what @Swarnim114 did in this PR but without using shutil and it's working for me.
@Swarnim114 are there any shortcomings of doing it this way?
neiljp added PR awaiting update 4 participants
closes #1536
What does this PR do, and why?
Adds a Terminal size label under the "Detected Environment " in About popup
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit
Visual changes