Create Task
Maniphest T353570

Clean up old ParserCache serialization test cases
Open, Needs TriagePublic
Actions

Description

We don't need to test the PHP serialization any more, and we don't need to test versions as far back as 1.35. Just "the last version" and "the next version" should be sufficient.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Warn if PHP serialization of ParserOutput occursmediawiki/coremaster+7 -0
Prepare to use JSON serialization for PageEditStashmediawiki/coremaster+333 -92
Remove test case support for PHP serialization of ParserOutputmediawiki/coremaster+9 -25
Deprecate GhostFieldAccessTrait.phpmediawiki/coreREL1_44+3 -0
Remove PHP (de-)serialization support from ParserOutputmediawiki/coremaster+11 -349
Deprecate GhostFieldAccessTrait.phpmediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Dec 16 2023, 3:33 AM
cscott added subtasks: T279942: Why the type of values in mCategories in serialized data for ParserOutputTest::testDeserialization is int?, T293513: Deprecate and remove ParserOutput::setTOCHTML(), T343050: Remove ParserOutput::$mWarningMsgs workaround from ParserCacheSerializationTestCases.
Umherirrender subscribed.Dec 16 2023, 9:00 PM

This could also help for php8.2 as dynamic properties, even after serialization, are deprecated (T314099), at the moment the tests are skipped on php8.2 (1b9809b3). Not sure if the check for ghost fields could make problems, but the json format should not be a problem (hopefully).

MSantos moved this task from Backlog to Later on the Content-Transform-Team board.Dec 21 2023, 3:08 PM
Umherirrender unsubscribed.Feb 11 2024, 12:07 AM
cscott mentioned this in T355952: "PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::setTOCHTML was deprecated in MediaWiki 1.40" in PHPUnit tests.Feb 22 2024, 3:29 PM
cscott added a parent task: T355952: "PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::setTOCHTML was deprecated in MediaWiki 1.40" in PHPUnit tests.
cscott added a subscriber: Umherirrender.Mar 11 2024, 6:46 PM

As mentioned in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1000086 and by @Umherirrender above there's a bunch of "ghost field" serialization compat that can get stripped out too.

Umherirrender unsubscribed.Apr 4 2024, 6:29 PM
cscott added a comment.EditedApr 23 2024, 4:32 PM

Clarified the current compatibility policy with @daniel (prompted by a discussion with @Krinkle on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1023098) and documented the policy at https://www.mediawiki.org/wiki/Manual:Parser_cache/Serialization_compatibility:

tl;dr the current policy is to retain compatibility with two LTS releases. Right now (1.43.0-wmf.2) that's back to 1.35 and PHP serialization, even though serializing as PHP was turned off in 1.39 (697f28df320d957676ad2cbaaeedba9b2e80bdfa).

So that means this task is blocked until 1.44.0 is branched; at which point we can remove PHP serialization support (including "reading PHP serialized objects" in ParserCache and the 'ghost field' support) as well as the serialization test files before 1.39 (aka *.serialized and 1.35-*, 1.36-*, and 1.38-* in tests/phpunit/data/ParserCache).

gerritbot added a comment.May 23 2025, 10:11 AM

Change #1149627 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Remove PHP (de-)serialization support from ParserOutput

https://gerrit.wikimedia.org/r/1149627

gerritbot added a project: Patch-For-Review.May 23 2025, 10:11 AM
gerritbot added a comment.May 23 2025, 4:20 PM

Change #1149698 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Deprecate GhostFieldAccessTrait.php

https://gerrit.wikimedia.org/r/1149698

gerritbot added a comment.May 23 2025, 5:11 PM

Change #1149698 merged by jenkins-bot:

[mediawiki/core@master] Deprecate GhostFieldAccessTrait.php

https://gerrit.wikimedia.org/r/1149698

gerritbot added a comment.May 23 2025, 5:17 PM

Change #1149627 merged by jenkins-bot:

[mediawiki/core@master] Remove PHP (de-)serialization support from ParserOutput

https://gerrit.wikimedia.org/r/1149627

Maintenance_bot removed a project: Patch-For-Review.May 23 2025, 5:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 23 2025, 6:00 PM
gerritbot added a comment.May 23 2025, 10:05 PM

Change #1149777 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/core@REL1_44] Deprecate GhostFieldAccessTrait.php

https://gerrit.wikimedia.org/r/1149777

gerritbot added a project: Patch-For-Review.May 23 2025, 10:05 PM
gerritbot added a comment.May 26 2025, 10:07 PM

Change #1149777 merged by jenkins-bot:

[mediawiki/core@REL1_44] Deprecate GhostFieldAccessTrait.php

https://gerrit.wikimedia.org/r/1149777

Maintenance_bot removed a project: Patch-For-Review.May 26 2025, 10:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes.May 26 2025, 11:00 PM
gerritbot added a comment.Jun 17 2025, 7:55 PM

Change #1160243 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove test case support for PHP serialization of ParserOutput

https://gerrit.wikimedia.org/r/1160243

gerritbot added a project: Patch-For-Review.Jun 17 2025, 7:55 PM
gerritbot added a comment.Jun 23 2025, 8:31 AM

Change #1160243 merged by jenkins-bot:

[mediawiki/core@master] Remove test case support for PHP serialization of ParserOutput

https://gerrit.wikimedia.org/r/1160243

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2025, 9:31 AM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.8; 2025-07-01); removed MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).Jun 24 2025, 3:02 PM
gerritbot added a comment.Jul 1 2025, 4:38 PM

Change #1165572 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Warn if PHP serialization of ParserOutput occurs

https://gerrit.wikimedia.org/r/1165572

gerritbot added a project: Patch-For-Review.Jul 1 2025, 4:38 PM
gerritbot added a comment.Jul 1 2025, 7:12 PM

Change #1165581 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Use JSON serialization for PageEditStash

https://gerrit.wikimedia.org/r/1165581

cscott mentioned this in T398656: PageEditStash (and Content) should use JSON serialization.Jul 3 2025, 6:28 PM
gerritbot added a comment.Aug 19 2025, 8:57 PM

Change #1165581 merged by jenkins-bot:

[mediawiki/core@master] Prepare to use JSON serialization for PageEditStash

https://gerrit.wikimedia.org/r/1165581

gerritbot added a comment.Sep 3 2025, 6:28 PM

Change #1165572 merged by jenkins-bot:

[mediawiki/core@master] Warn if PHP serialization of ParserOutput occurs

https://gerrit.wikimedia.org/r/1165572

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2025, 6:30 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.18; 2025-09-09); removed MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Sep 3 2025, 7:00 PM
cscott closed subtask T293513: Deprecate and remove ParserOutput::setTOCHTML() as Resolved.Wed, Mar 18, 4:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits