fix memory leak #99
Closed
fix memory leak #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
this function leaked memory when the standard `liq_image_create_rgba`/`liq_quantize_image`/`liq_write_remapped_image` combo is used on large images (or forced to use conserved memory). fixed by checking if the temporary array is already allocated by either `liq_image_create_rgba` and `liq_write_remapped_image`. Signed-off-by: mateoconlechuga <matthewwaltzis@gmail.com>
Contributor Author
| I realize that not many people are still using the |
kornelski reviewed Nov 4, 2022
| if (!img->temp_row) return NULL; | ||
| } | ||
| | ||
| img->temp_f_row = NULL; |
Member
There was a problem hiding this comment.
I don't understand why is it nulled here. If it was null already (as should have been from the init earlier) then it's unnecessary. If it wasn't null, that's a leak.
Member
| Thanks for reporting this. I've fixed it in 113567c |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
this function leaked memory when the standard
liq_image_create_rgba/liq_quantize_image/liq_write_remapped_imagecombo is used on large images (or forced to use conserved memory).fixed by checking if the temporary array is already allocated by either
liq_image_create_rgbaandliq_write_remapped_image.