Skip to content

[Zero-Dim] support input 0D Tensor for sundary api#47734

Merged
zhwesky2010 merged 2 commits intoPaddlePaddle:developfrom
zhwesky2010:0d_sundary1
Nov 8, 2022
Merged

[Zero-Dim] support input 0D Tensor for sundary api#47734
zhwesky2010 merged 2 commits intoPaddlePaddle:developfrom
zhwesky2010:0d_sundary1

Conversation

@zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Nov 7, 2022 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

为无需测反向的这类API支持输入0D Tensor，例如判断类、属性等API，如下：

paddle.nn.functional.linear paddle.is_complex paddle.is_floating_point paddle.is_integer paddle.is_tensor paddle.isfinite paddle.isinf paddle.isnan paddle.isclose paddle.clone paddle.assign paddle.Tensor.item paddle.Tensor.tolist paddle.Tensor.numpy paddle.numel paddle.rank paddle.shape
@paddle-bot
Copy link

paddle-bot bot commented Nov 7, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
XieYunshen
XieYunshen previously approved these changes Nov 7, 2022
View reviewed changes
jeff41404
jeff41404 reviewed Nov 8, 2022
View reviewed changes
python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py Outdated
{'func': paddle.subtract, 'cls_method': '__sub__'},
{'func': paddle.multiply, 'cls_method': '__mul__'},
{'func': paddle.divide, 'cls_method': '__div__'},
{'func': paddle.subtract, 'cls_method': '__sub__'},
Copy link
Contributor

@jeff41404 jeff41404 Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did paddle.subtract repeat 4 times, while paddle.add 2 times, what is the meaning of repeat in the list?
Copy link
Contributor

@jeff41404 jeff41404 Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add paddle.maximum and paddle.minimum ?
Copy link
Contributor Author

@zhwesky2010 zhwesky2010 Nov 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前只支持了部分二元，就是这个list中包含的。这两个还未支持0D，后面会加。
Copy link
Contributor Author

@zhwesky2010 zhwesky2010 Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did paddle.subtract repeat 4 times, while paddle.add 2 times, what is the meaning of repeat in the list?

Some mistake, have fixed it.
Copy link
Contributor

@jeff41404 jeff41404 Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks
jeff41404
jeff41404 reviewed Nov 8, 2022
View reviewed changes
python/paddle/fluid/tests/unittests/test_zero_dim_tensor.py
paddle.floor_mod,
paddle.logical_and,
paddle.logical_or,
paddle.logical_xor,
Copy link
Contributor

@jeff41404 jeff41404 Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add paddle.bitwise_and/or/xor ?
Copy link
Contributor Author

@zhwesky2010 zhwesky2010 Nov 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已添加
jeff41404
jeff41404 approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@zhwesky2010 zhwesky2010 merged commit 3198af2 into PaddlePaddle:develop Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@zhwesky2010 @jeff41404 @XieYunshen