【Hackathon 4th No.24】为 Paddle 新增 paddle.sparse.is_nan 稀疏 API by thunder95 · Pull Request #51513 · PaddlePaddle/Paddle

thunder95 · 2023-03-11T16:18:06Z

PR types

New features

PR changes

APIs

Describe

完成第四期第24项目开发任务: https://github.com/PaddlePaddle/community/blob/master/hackthon_4th/%E3%80%90PaddlePaddle%20Hackathon%204%E3%80%91%20%E6%A0%B8%E5%BF%83%E6%A1%86%E6%9E%B6%E5%BC%80%E6%BA%90%E8%B4%A1%E7%8C%AE%20API%20%E5%BC%80%E5%8F%91%E4%BB%BB%E5%8A%A1%E5%90%88%E9%9B%86.md#task24
isnan 检查输入Tensor 的每一个值是否为 +/-NaN, 并返回布尔型结果。目前在 PaddlePaddle 中，对于稀疏Ｔensor还没有支持isnan的API。

RFC设计文档: PaddlePaddle/community#415
中文api文档:PaddlePaddle/docs#5705

… develop

…velop

… develop

…velop

paddle-bot · 2023-03-11T16:18:11Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010 · 2023-03-14T14:21:40Z

paddle/phi/kernels/sparse/unary_kernel.h

 }

+template <typename T, typename Context>
+SparseCooTensor IsnanCoo(const Context& dev_ctx, const SparseCooTensor& x) {


这个额外地C++ API可以删掉，一般用kernel表示C++ api就可以

你这个删掉没

zhwesky2010 · 2023-03-14T14:23:07Z

没有支持静态图，可能需要 @zkh2016 帮忙看下静态图的应该怎么写

zkh2016 · 2023-03-15T06:11:19Z

没有支持静态图，可能需要 @zkh2016 帮忙看下静态图的应该怎么写

coo格式的静态图单测还是建议加下。test_sparse_norm_op.py和test_sparse_conv_op.py有测试例子，可以先用这种方式测下，验下正确性。

thunder95 · 2023-03-16T06:32:50Z

test_sparse_norm_op

@zhouwei25 @zkh2016 这个算子有点特殊，计算结果是bool型，在to_dense或return_numpy=True的时候，都会报错。辛苦两位老师给个建议。

InvalidArgumentError: The type of data we are trying to retrieve (float32) does not match the type of data (bool) currently contained in the container.
1220: [Hint: Expected dtype() == paddle::experimental::CppTypeToDataType::Type(), but received dtype():1 != paddle::experimental::CppTypeToDataType::Type():10.] (at /paddle/paddle/phi/core/dense_tensor.cc:163)

zkh2016 · 2023-03-16T08:23:37Z

test_sparse_norm_op

@zhouwei25 @zkh2016 这个算子有点特殊，计算结果是bool型，在to_dense或return_numpy=True的时候，都会报错。辛苦两位老师给个建议。

InvalidArgumentError: The type of data we are trying to retrieve (float32) does not match the type of data (bool) currently contained in the container. 1220: [Hint: Expected dtype() == paddle::experimental::CppTypeToDataType::Type(), but received dtype():1 != paddle::experimental::CppTypeToDataType::Type():10.] (at /paddle/paddle/phi/core/dense_tensor.cc:163)

当前to_dense还没注册bool类型，你可以先注册一个，测测看。

thunder95 · 2023-03-19T15:55:46Z

@zhouwei25 @zkh2016
已尝试注册bool类型，依旧是同样的报错。

有个不明白的地方，虽然我使用的是IsfiniteInferMeta，　返回的稀疏张量的dtype应该是bool才对，但是打印出来仍旧是float类型，所以定位在下面的内存或显存分配会发生报错，因为x的dtype是bool类型，但是模板Ｔ是float：

template <typename T, typename Context> DenseTensor CooToDense(const Context& dev_ctx, const SparseCooTensor& x) const T* x_data = values.data<T>(); ===> 出现类型转换错误
打印稀疏张量的时候，dtype并不是bool类型，所以注册bool类型没有产生效果

Tensor(shape=[2, 2, 2], dtype=paddle.float64, place=Place(gpu:0), stop_gradient=True, indices=[[0, 0, 1, 1], [1, 1, 1, 1], [0, 1, 0, 1]], values=[False, False, False, True ])

zkh2016 · 2023-03-20T09:33:58Z

@zhouwei25 @zkh2016 已尝试注册bool类型，依旧是同样的报错。

有个不明白的地方，虽然我使用的是IsfiniteInferMeta，　返回的稀疏张量的dtype应该是bool才对，但是打印出来仍旧是float类型，所以定位在下面的内存或显存分配会发生报错，因为x的dtype是bool类型，但是模板Ｔ是float：

template <typename T, typename Context> DenseTensor CooToDense(const Context& dev_ctx, const SparseCooTensor& x) const T* x_data = values.data<T>(); ===> 出现类型转换错误 打印稀疏张量的时候，dtype并不是bool类型，所以注册bool类型没有产生效果

Tensor(shape=[2, 2, 2], dtype=paddle.float64, place=Place(gpu:0), stop_gradient=True, indices=[[0, 0, 1, 1], [1, 1, 1, 1], [0, 1, 0, 1]], values=[False, False, False, True ])

可能需要辛苦你进一步定位下，我看了下当前是通过DEFINE_SPARSE_UNARY_KERNEL这个宏定义is_nan的kernel的，这里面重新创建了out，所以类型可能变了。

… is_nan_sparse

thunder95 · 2023-03-22T02:14:02Z

@zhouwei25 @zkh2016 辛苦两位老师再review一下

… is_nan_sparse

zhwesky2010 · 2023-03-28T06:51:19Z

paddle/phi/api/yaml/sparse_ops.yaml

+ args : (Tensor x)
+ output : Tensor(out)
+ infer_meta :
+ func : IsfiniteInferMeta


这个名字不太对？

IsfiniteInferMeta吗？最新提交已修改成unchanged

@zhouwei25 如果改成unchanged，还是会报错，最新提交又修改回IsfiniteInferMeta
InvalidArgumentError: The type of data we are trying to retrieve (float32) does not match the type of data (bool) currently contained in the container.

@zhouwei25 如果改成unchanged，还是会报错，最新提交又修改回IsfiniteInferMeta InvalidArgumentError: The type of data we are trying to retrieve (float32) does not match the type of data (bool) currently contained in the container.

就是命名风格有点问题，这个不是IsNanInferMeta吗

@zhouwei25 IsfiniteInferMeta是参考dense tensor那里设计的IsfiniteInferMeta，考虑到代码可能会冗余就这么直接复用了，老师建议这个地方是需要单独写一个IsNanInferMeta吗

PD_REGISTER_INFER_META_FN(isnan, phi::IsfiniteInferMeta);

好复用也可以

zhwesky2010 · 2023-03-28T06:52:09Z

paddle/phi/kernels/sparse/unary_kernel.h

 }

+template <typename T, typename Context>
+SparseCooTensor IsnanCoo(const Context& dev_ctx, const SparseCooTensor& x) {


你这个删掉没

zhwesky2010 · 2023-03-28T06:52:20Z

paddle/phi/kernels/sparse/unary_kernel.h

+}
+
+template <typename T, typename Context>
+SparseCooTensor IsnanCsr(const Context& dev_ctx, const SparseCooTensor& x) {


这个删掉，需要kernel就可以

zhwesky2010 · 2023-03-28T06:54:36Z

paddle/phi/kernels/sparse/impl/unary_kernel_impl.h

 }

+template <typename T, typename Context>
+void IsnanCooKernel(const Context& dev_ctx,


这个用目前的公共组件，宏函数来注册kernel。可以复用减少代码

@zhouwei25 公共组件不能满足这个算子，因为emptylike会创建一个相同类型的输出tensor，而这个算子输出是bool型的，所以这里单独写了个kernel。

@zhouwei25 公共组件不能满足这个算子，因为emptylike会创建一个相同类型的输出tensor，而这个算子输出是bool型的，所以这里单独写了个kernel。

OK

… is_nan_sparse

…nto is_nan_sparse

… is_nan_sparse

zhwesky2010

LGTM

jeff41404

LGTM

sunzhongkai588 · 2023-03-30T08:41:53Z

python/paddle/sparse/unary.py

+ Return whether every element of input tensor is `NaN` or not, requiring x to be a SparseCooTensor or SparseCsrTensor.
+
+ Args:
+ x (Tensor): The input tensor, it's data type should be float16, float32, float64, int32, int64.


中文文档中 '可以为 Coo 或 Csr 格式' 可以表达出来

@sunzhongkai588 已修改

… is_nan_sparse

sunzhongkai588

LGTM

ZzSean

LGTM for CI-OP-Benchmark

thunder95 added 11 commits February 20, 2023 16:32

untracked files

c8ae296

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

6aa02f0

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d599110

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

264894d

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

98d1e1c

… develop

Merge branch 'develop' of https://github.com/thunder95/Paddle into de…

b958122

…velop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

760e099

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

e16076d

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

085c7a6

… develop

Merge branch 'develop' of https://github.com/thunder95/Paddle into de…

b1edf68

…velop

to_dense error

366305e

remove unused files

06abd01

paddle-bot bot added the contributor External developers label Mar 11, 2023

luotao1 assigned luotao1, Ligoml and zhwesky2010 Mar 13, 2023

luotao1 added the API label Mar 13, 2023

thunder95 mentioned this pull request Mar 13, 2023

【PaddlePaddle Hackathon 第四期】任务总览 #51281

Closed

zhwesky2010 reviewed Mar 14, 2023

View reviewed changes

add static

7399da9

thunder95 requested a review from zhwesky2010 March 16, 2023 06:33

thunder95 added 2 commits March 21, 2023 08:32

bool_dtype

daaa4d5

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

de93190

… is_nan_sparse

fix sample code

0f13d4e

thunder95 added 4 commits March 22, 2023 05:37

values_coo_grad bool

fb34f98

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

7a70698

… is_nan_sparse

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

3fb3fa5

… is_nan_sparse

restart ci

2284e65

zhwesky2010 reviewed Mar 28, 2023

View reviewed changes

thunder95 added 3 commits March 28, 2023 09:52

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

94f9bc5

… is_nan_sparse

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

0075dcf

… is_nan_sparse

remove duplicate def

f323b0a

thunder95 requested a review from zhwesky2010 March 28, 2023 14:29

thunder95 added 4 commits March 29, 2023 00:30

Merge branch 'is_nan_sparse' of https://github.com/thunder95/Paddle i…

9282ed7

…nto is_nan_sparse

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

33a5ec8

… is_nan_sparse

fix out type error

fe595a5

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

cdeeacd

… is_nan_sparse

zhwesky2010 previously approved these changes Mar 29, 2023

View reviewed changes

jeff41404 previously approved these changes Mar 29, 2023

View reviewed changes

luotao1 assigned sunzhongkai588 Mar 29, 2023

sunzhongkai588 reviewed Mar 30, 2023

View reviewed changes

thunder95 added 2 commits March 30, 2023 10:10

optimize doc

015f94e

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

987d523

… is_nan_sparse

thunder95 dismissed stale reviews from jeff41404 and zhwesky2010 via 987d523 March 30, 2023 10:11

thunder95 requested a review from sunzhongkai588 March 30, 2023 14:57

zhwesky2010 approved these changes Mar 31, 2023

View reviewed changes

sunzhongkai588 approved these changes Apr 3, 2023

View reviewed changes

ZzSean approved these changes Apr 3, 2023

View reviewed changes

luotao1 closed this Apr 3, 2023

luotao1 reopened this Apr 3, 2023

luotao1 merged commit b7db6af into PaddlePaddle:develop Apr 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 4th No.24】为 Paddle 新增 paddle.sparse.is_nan 稀疏 API #51513

【Hackathon 4th No.24】为 Paddle 新增 paddle.sparse.is_nan 稀疏 API #51513
luotao1 merged 31 commits intoPaddlePaddle:developfrom
thunder95:is_nan_sparse

thunder95 commented Mar 11, 2023

paddle-bot bot commented Mar 11, 2023

zhwesky2010 Mar 14, 2023

zhwesky2010 Mar 28, 2023

zhwesky2010 commented Mar 14, 2023

zkh2016 commented Mar 15, 2023 •

edited

Loading

thunder95 commented Mar 16, 2023

zkh2016 commented Mar 16, 2023

thunder95 commented Mar 19, 2023 •

edited

Loading

zkh2016 commented Mar 20, 2023

thunder95 commented Mar 22, 2023

zhwesky2010 Mar 28, 2023

thunder95 Mar 28, 2023

thunder95 Mar 29, 2023

zhwesky2010 Mar 29, 2023

thunder95 Mar 29, 2023

thunder95 Mar 29, 2023

zhwesky2010 Mar 29, 2023

zhwesky2010 Mar 28, 2023

zhwesky2010 Mar 28, 2023

thunder95 Mar 28, 2023

zhwesky2010 Mar 28, 2023

thunder95 Mar 28, 2023

zhwesky2010 Mar 29, 2023

zhwesky2010 left a comment

jeff41404 left a comment

sunzhongkai588 Mar 30, 2023

thunder95 Mar 30, 2023

sunzhongkai588 left a comment

ZzSean left a comment

Labels

8 participants

Conversation

thunder95 commented Mar 11, 2023

PR types

PR changes

Describe

paddle-bot bot commented Mar 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 commented Mar 14, 2023

zkh2016 commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

thunder95 commented Mar 16, 2023

zkh2016 commented Mar 16, 2023

thunder95 commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

zkh2016 commented Mar 20, 2023

thunder95 commented Mar 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunzhongkai588 left a comment

Choose a reason for hiding this comment

ZzSean left a comment

Choose a reason for hiding this comment

Labels

8 participants

zkh2016 commented Mar 15, 2023 •

edited

Loading

thunder95 commented Mar 19, 2023 •

edited

Loading