Skip to content

Fix for session missing init callback, does not need to be GenServer #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fix for session missing init callback, does not need to be GenServer #26

merged 1 commit into from
Apr 30, 2019

Conversation

@holsee
Copy link
Contributor

@holsee holsee commented Apr 30, 2019

It would appear that the ChromeRemoteInterface.Session does not need to be a GenServer.

This will also remove the following warning:

warning: function init/1 required by behaviour GenServer is not implemented (in module ChromeRemoteInterface.Session). We will inject a default implementation for now: def init(init_arg) do {:ok, init_arg} end
@andrewvy andrewvy merged commit e2612bb into andrewvy:master Apr 30, 2019
@andrewvy
Copy link
Owner

andrewvy commented Apr 30, 2019

Whoops, probably a left-over from initial thinking. Thank you!
@holsee holsee deleted the fix/session-init branch April 30, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@holsee @andrewvy