[MRELEASE-1054] Support for excluding submodules changes.#196
Merged
elharo merged 2 commits intoapache:masterfrom Dec 13, 2024
Merged
[MRELEASE-1054] Support for excluding submodules changes.#196elharo merged 2 commits intoapache:masterfrom
elharo merged 2 commits intoapache:masterfrom
Conversation
elharo requested changes Aug 14, 2023
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java Outdated Show resolved Hide resolved
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java Outdated Show resolved Hide resolved
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java Outdated Show resolved Hide resolved
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java Outdated Show resolved Hide resolved
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java Outdated Show resolved Hide resolved
elharo requested changes Aug 17, 2023
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java Outdated Show resolved Hide resolved
wuwen5 force-pushed the MRELEASE-1054 branch from 8844aea to e7eb887 Compare 
Contributor Author
| @elharo I have addressed the issues you pointed out, and I kindly request you to review the modified code. If you have any further suggestions or if there are additional changes needed, please let me know. |
elharo previously requested changes Dec 20, 2023
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java Outdated Show resolved Hide resolved
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java Outdated Show resolved Hide resolved
elharo reviewed Dec 9, 2024
...elease-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java Show resolved Hide resolved
wuwen5 force-pushed the MRELEASE-1054 branch from 09f25d4 to e236be7 Compare elharo reviewed Dec 12, 2024
...elease-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java Outdated Show resolved Hide resolved
elharo approved these changes Dec 13, 2024
...ease-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractScmCommitPhase.java Show resolved Hide resolved
elharo requested changes Dec 13, 2024
Contributor
elharo left a comment
elharo left a comment There was a problem hiding this comment.
Please run mvn spotless:apply to format
wuwen5 force-pushed the MRELEASE-1054 branch from 02e42c5 to 7848425 Compare wuwen5 force-pushed the MRELEASE-1054 branch from 7848425 to 3b01698 Compare elharo approved these changes Dec 13, 2024
| Resolve #1237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MRELEASE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MRELEASE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-itsto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
As described in [MRELEASE-1054], when I use the Git submodule in a project,
release: preparewill fail. I really need to support the release of the Git submodule, and I also have a pull request in the maven-scm project apache/maven-scm#179.