Skip to content

Adding ability to pass through idle_in_transaction_session_tim…#2049

Merged
brianc merged 4 commits intobrianc:masterfrom
aheuermann:idle_in_transaction_session_timeout
Dec 29, 2019
Merged

Adding ability to pass through idle_in_transaction_session_tim…#2049
brianc merged 4 commits intobrianc:masterfrom
aheuermann:idle_in_transaction_session_timeout

Conversation

@aheuermann
Copy link
Contributor

…eout

Allowing for passing in the idle_in_transaction_session_timeout option.

@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from ce7d7a8 to 26a6f2b Compare December 27, 2019 21:24
Copy link
Owner

@brianc brianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks great - good tests! Thanks for the PR, I'll get this released today or tomorrow!

@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from 26a6f2b to bb8e806 Compare December 27, 2019 21:31
@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from 3169ffc to 6363778 Compare December 27, 2019 22:05
@aheuermann
Copy link
Contributor Author

Note: it looks like idle_in_transaction_session_timeout at the client-level was added in v10, is there a simple way to disable the tests for all versions < v10?

@brianc
Copy link
Owner

brianc commented Dec 27, 2019

no rush here - code changes look good...I'll merge it once the tests pass. 👍

@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from 46f0113 to 8390432 Compare December 28, 2019 15:02
@brianc brianc merged commit 6b39253 into brianc:master Dec 29, 2019
@brianc
Copy link
Owner

brianc commented Dec 29, 2019

published with pg@7.17.0 - thanks!

@psnehanshu
Copy link

This is confusing, there's also a idle_in_transaction_session_timeout parameter available in Postgres. Does it override that value at the connection level, or is this handled at pg level?

@charmander
Copy link
Collaborator

charmander commented Oct 27, 2022

there's also a idle_in_transaction_session_timeout parameter available in Postgres

@psnehanshu That is exactly what this option sets for a connection, and nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants