Immediately unref() maxLifetimeSeconds Timeout object to prevent blocking allowExitOnIdle#2721
Merged
brianc merged 1 commit intobrianc:masterfrom May 13, 2022
Merged
Conversation
charmander approved these changes Mar 17, 2022
Owner
| Hey sorry for the headache here but CI was broken. I fixed it yesterday...would you be able to rebase onto master? Then the tests should pass and we can merge this up and get a release out! Thank you so much for contributing! ❤️ |
…king allowExitOnIdle
Contributor Author
| I believe the pull request was updated correctly. …On Wed, May 11, 2022 at 11:32 AM Brian C ***@***.***> wrote: Hey sorry for the headache here but CI was broken. I fixed it <#2743> yesterday...would you be able to rebase onto master? Then the tests should pass and we can merge this up and get a release out! Thank you so much for contributing! ❤️ — Reply to this email directly, view it on GitHub <#2721 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMCLASE7YEAXUYO74ALIGILVJP4KJANCNFSM5Q5G7PZQ> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Owner
| awesome! Thanks @ChrisWritable - I'll get this released in a few days at most...just waiting on a few other PRs to rebsase their changes so I can bundle up stuff for a new version. Thanks for your contribution. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##2698