chore(breaking): update all packages; require node >=18 #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mdjastrzebski approved these changes Sep 22, 2023
Member
mdjastrzebski left a comment
mdjastrzebski left a comment There was a problem hiding this comment.
LGTM. Not sure about min Node 16. Might want to consult that with @thymikee
Member
| Node 16 is past its EOL. Let's go with 18 |
thymikee changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Update all packages to the latest version. This is a breaking change for supported node version as ts-eslint is dropping support in v6.
https://typescript-eslint.io/blog/announcing-typescript-eslint-v6#tooling-breaking-changes
Test plan
Run tests and verify if it passes. Use updated version in project and verify if it works correctly.