Skip to content

Conversation

@thomasgassmann
Copy link
Contributor

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "remove-duplicate-on" git@github.com:thomasgassmann/docker-py.git somewhere $ cd somewhere $ git commit --amend -s --no-edit $ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Thomas Gassmann <thomas.gassmann@hotmail.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shin-

@milas milas merged commit 3f0095a into docker:main Jul 30, 2022
@milas milas added this to the 6.0.0 milestone Jul 30, 2022
@thomasgassmann thomasgassmann deleted the remove-duplicate-on branch July 30, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants