Skip to content

Use preexec_func always #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

Use preexec_func always #2920

merged 1 commit into from
Aug 2, 2022

Conversation

@q0w
Copy link
Contributor

@q0w q0w commented Dec 1, 2021

preexec_func is still None if it is win32
@q0w
Use preexec_func always
d6706e8 
`preexec_func` is still None if it is win32 Signed-off-by: q0w <43147888+q0w@users.noreply.github.com>
milas
milas reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the issue you're trying to solve here?

preexec_fn is set for non-Windows platforms only:

docker-py/docker/transport/sshconn.py

Lines 48 to 52 in b2a18d7

preexec_func = None
if not constants.IS_WINDOWS_PLATFORM:
def f():
signal.signal(signal.SIGINT, signal.SIG_IGN)
preexec_func = f

@q0w
Copy link
Contributor Author

q0w commented Jul 30, 2022 •
edited
Loading

so if windows it would still be none

docker-py/docker/transport/sshconn.py

Line 48 in b2a18d7

preexec_func = None

So you dont need to check it twice
@milas milas self-assigned this Aug 2, 2022
@milas milas added this to the 6.0.0 milestone Aug 2, 2022
@milas milas merged commit ab5e927 into docker:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@q0w @milas