Support cgroupns option in containers.run/containers.create #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi, What needs to be completed to get this merged? It is currently blocking ansible-collections/community.docker#338 Can I help somehow? |
| I am very interesting in getting this merge too (running containers with saltstack on debian >= buster requires this patch IFAIU). |
Contributor Author
| We are blocked by this too. Unfortunately the docker-py seems to be dead-ish atm. The commits on master give some hope... |
Signed-off-by: David Otto <ottodavid@gmx.net>
david0 force-pushed the feature-add-cgroupns branch from 749783e to d5df1f6 Compare 
milas approved these changes Jul 29, 2022
milas added a commit to milas/docker-py that referenced this pull request Jul 29, 2022
See docker#2930. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Contributor Author
| @milas Thanks a lot! 🎉 |
milas added a commit to milas/docker-py that referenced this pull request Aug 12, 2022
See docker#2930. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas added a commit that referenced this pull request Aug 12, 2022
See #2930. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
cgroupns=hostis needs be used to run systemd v2 containers, which needs to be used with docker desktop >=4.3.0 (docker/for-mac#6073)