deps: upgrade & remove unnecessary dependencies #3014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `requirements.txt` and `setup.py` had a lot of extra transitive dependencies to try and address various SSL shortcomings from the Python ecosystem. Thankfully, between modern Python versions (3.6+) and corresponding `requests` versions (2.26+), this is all unnecessary now! As a result, a bunch of transitive dependencies have been removed from `requirements.txt`, the minimum version of `requests` increased, and the `tls` extra made into a no-op. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas commented Jul 27, 2022
| If you are intending to connect to a docker host via TLS, add `docker[tls]` to your requirements instead, or install with pip: | ||
| | ||
| pip install docker[tls] | ||
| > Older versions (< 6.0) required installing `docker[tls]` for SSL/TLS support. |
Contributor Author
There was a problem hiding this comment.
See #3013 - thinking we should release as v6.0.0 next 🙃
glours approved these changes Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
requirements.txtandsetup.pyhad a lot of extra transitivedependencies to try and address various SSL shortcomings from the
Python ecosystem.
Thankfully, between modern Python versions (3.6+) and corresponding
requestsversions (2.26+), this is all unnecessary now!As a result, a bunch of transitive dependencies have been removed
from
requirements.txt, the minimum version ofrequestsincreased,and the
tlsextra made into a no-op.