ci: add workflow for releases #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GitHub Actions workflow to create a release: will upload to PyPI and create a GitHub release with the `sdist` and `bdist_wheel` as well. The version code is switched to `setuptools_scm` to work well with this flow (e.g. avoid needing to write a script that does a `sed` on the version file and commits as part of release). Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
nicksieger suggested changes Jul 29, 2022
Contributor Author
Ha yeah everything is pretty much lifted straight from their docs! It's funky but less crazy than most other solutions I've seen (and is "blessed" by pypa that maintains pip etc) |
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
nicksieger approved these changes Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
GitHub Actions workflow to create a release: will upload to PyPI
and create a GitHub release with the
sdistandbdist_wheelas well.
The version code is switched to
setuptools_scmto work wellwith this flow (e.g. avoid needing to write a script that does
a
sedon the version file and commits as part of release).