Skip to content

Conversation

@milas
Copy link
Contributor

@milas milas commented Jul 28, 2022

This is the last of the dependency upgrades - I didn't do it with the others because there was no test coverage for the websocket version of log streaming, so this PR adds a basic one along with the upgrade.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas added the dependencies Pull requests that update a dependency file label Jul 28, 2022
@milas milas requested a review from a team July 28, 2022 20:38
@milas milas self-assigned this Jul 28, 2022
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas
Copy link
Contributor Author

milas commented Jul 29, 2022

FYI I had to mark the test as xfail for the SSL case -- it looks like that's actually broken right now when you're using DOCKER_CERT_PATH because we don't seem to propagate the certs to the websocket connection 🙈

@milas milas merged commit 26064dd into docker:main Jul 29, 2022
@milas milas deleted the upgrade-ws branch July 29, 2022 15:09
@milas milas added this to the 6.0.0 milestone Jul 30, 2022
akx added a commit to valohai/docker-py that referenced this pull request May 10, 2023
Also bump minimum version to that prescribed by docker#3022
akx added a commit to valohai/docker-py that referenced this pull request May 10, 2023
Also bump minimum version to that prescribed by docker#3022 Signed-off-by: Aarni Koskela <akx@iki.fi>
akx added a commit to valohai/docker-py that referenced this pull request May 12, 2023
Also bump minimum version to that prescribed by docker#3022 Signed-off-by: Aarni Koskela <akx@iki.fi>
akx added a commit to valohai/docker-py that referenced this pull request Jun 6, 2023
Also bump minimum version to that prescribed by docker#3022 Signed-off-by: Aarni Koskela <akx@iki.fi>
akx added a commit to valohai/docker-py that referenced this pull request Aug 15, 2023
Also bump minimum version to that prescribed by docker#3022 Signed-off-by: Aarni Koskela <akx@iki.fi>
sthagen pushed a commit to sthagen/docker-docker-py that referenced this pull request Nov 20, 2023
Also bump minimum version to that prescribed by docker#3022 Signed-off-by: Aarni Koskela <akx@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

2 participants