Avoid stripping characters in volume names #3073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Loïc Leyendecker <loic.leyendecker@gmail.com>
loicleyendecker requested review from aiordache and ulyssessouza as code owners 
milas approved these changes Dec 1, 2022
Contributor
milas left a comment
milas left a comment There was a problem hiding this comment.
Thanks for the PR! Nice find 🙃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When a volume name ends in "r", "o", or "w", it currently gets stripped which results in a mount created on the host with an incorrect name. The fix simply consists in not using the
rstripmethod but manually checking for ":rw" and ":ro" at the end of the string.Signed-off-by: Loïc Leyendecker loic.leyendecker@gmail.com