Skip to content

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Mar 7, 2024

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

@vvoland vvoland self-assigned this Mar 7, 2024
robmry and others added 3 commits March 13, 2024 14:54
Inspect output for 'NetworkSettings.Networks.<network>.Aliases' includes the container's short-id (although it will be removed in API v1.45, in moby 26.0). Signed-off-by: Rob Murray <rob.murray@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
25.0 raised the minimum supported API verison: moby/moby#46887 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland requested a review from milas March 18, 2024 11:13
@vvoland vvoland requested a review from thaJeztah March 25, 2024 12:43
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should probably also look at @krissetto's PR to make this a better matrix (#3234)

@krissetto
Copy link
Contributor

LGTM

We should probably also look at @krissetto's PR to make this a better matrix (#3234)

I also included the updates that are in this PR, but i can rebase once we merge this :)

@vvoland vvoland merged commit 3d79ce8 into docker:main Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants