Skip to content

chore: upgrade eslint-plugin-node => eslint-plugin-n #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024
Merged

chore: upgrade eslint-plugin-node => eslint-plugin-n #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const js = require('@eslint/js');
const { FlatCompat } = require('@eslint/eslintrc');
const globals = require('globals');
const markdown = require('eslint-plugin-markdown');
const pluginN = require('eslint-plugin-n');
const eslintPluginConfig = require('eslint-plugin-eslint-plugin/configs/all');

const compat = new FlatCompat({
Expand All @@ -15,23 +16,12 @@ module.exports = [
...compat.extends(
'not-an-aardvark/node',
'plugin:eslint-comments/recommended',
'plugin:node/recommended',
'plugin:prettier/recommended',
'plugin:unicorn/recommended'
),
pluginN.configs['flat/recommended'],
{
languageOptions: { sourceType: 'commonjs' },
rules: {
'comma-dangle': [
Copy link
Contributor Author

@aladdin-add aladdin-add Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma-dangle is removed as: 1) we are using prettier now; 2) formatting rules has been deprecated.
'error',
{
arrays: 'always-multiline',
objects: 'always-multiline',
functions: 'never', // disallow trailing commas in function(es2017)
},
],
'require-jsdoc': 'error',
Copy link
Contributor Author

@aladdin-add aladdin-add Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require-jsdoc has been deprecated for years.

'eslint-comments/no-unused-disable': 'error',
'eslint-comments/require-description': 'error',

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-eslint-plugin": "file:./",
"eslint-plugin-markdown": "^3.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^16.6.2",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-unicorn": "^46.0.0",
"eslint-remote-tester": "^3.0.0",
Expand Down