Merged
Conversation
Member
UlisesGascon commented Oct 13, 2024
UlisesGascon commented - Based on https://github.com/nodejs/node/blob/main/CONTRIBUTING.md
- Related to [ONBOARDING] Express openjs-foundation/project-status#159
Member Author
| ping: @expressjs/express-tc |
Member
| It could be added as a comment in the PR messages like pkgjs does. ref: https://github.com/pkgjs/.github/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1 |
Member Author
| Great idea @bjohansebas. Would you mind to do a PR for that? :) |
ctcpip reviewed Oct 28, 2024
ctcpip approved these changes Oct 28, 2024
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
Closed
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR. Following the example in expressjs/express#6048 See https://github.com/openjs-foundation/project-status/issues/2
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR. Following the example in expressjs/express#6048 See https://github.com/openjs-foundation/project-status/issues/2
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR. Following the example in expressjs/express#6048 See https://github.com/openjs-foundation/project-status/issues/2
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR. Following the example in expressjs/express#6048 See https://github.com/openjs-foundation/project-status/issues/2
Merged
This was referenced Aug 15, 2025
ljharb added a commit to browserify/resolve that referenced this pull request Dec 4, 2025
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR. Following the example in expressjs/express#6048 / nvm-sh/nvm#3456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.