Skip to content

Conversation

@Xplouder
Copy link

@Xplouder Xplouder commented Jul 17, 2017

Let me know if the tests are mandatory or just optional.

@coveralls
Copy link

coveralls commented Jul 17, 2017

Coverage Status

Coverage decreased (-0.3%) to 99.581% when pulling 0a49b71 on Xplouder:feature/filter_by_users into 89d609e on gomoob:master.

@bgaillard
Copy link
Member

Hi @Xplouder and thanks for this new feature.

Let me know if the tests are mandatory or just optional.

Yes, since version 1.8.0 code coverage is 100%, to respect our quality standards we wish to keep 100% code coverage now.

So could you complete the unit tests associated to the Notification class to increase the code coverage ?

Thanks

…o filter the notification targets by user(s)
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3ef on Xplouder:feature/filter_by_users into 89d609e on gomoob:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3ef on Xplouder:feature/filter_by_users into 89d609e on gomoob:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3ef on Xplouder:feature/filter_by_users into 89d609e on gomoob:master.

@Xplouder
Copy link
Author

Xplouder commented Aug 3, 2017

@bgaillard Any ETA to get this merged?

MiraWaNeko added a commit to MiraWaNeko/php-pushwoosh that referenced this pull request Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants