Skip to content

Conversation

@BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Apr 5, 2025

I'm running into an issue while implementing nuxt-modules/i18n#3341

In the build it looks like the GeneratedTypeConfig interface gets renamed to GeneratedTypeConfig_2 and is no longer exported, which means we can't augment it.

This is what the type looks like in the build currently:

declare type GeneratedInstanceType = GeneratedTypeConfig_2 extends Record<'legacy', infer Legacy> ? Legacy : never; export { GeneratedTypeConfig }
@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Apr 5, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 5, 2025

Open in StackBlitz

@intlify/core

npm i https://pkg.pr.new/@intlify/core@2158 

@intlify/core-base

npm i https://pkg.pr.new/@intlify/core-base@2158 

@intlify/devtools-types

npm i https://pkg.pr.new/@intlify/devtools-types@2158 

@intlify/message-compiler

npm i https://pkg.pr.new/@intlify/message-compiler@2158 

petite-vue-i18n

npm i https://pkg.pr.new/petite-vue-i18n@2158 

@intlify/shared

npm i https://pkg.pr.new/@intlify/shared@2158 

vue-i18n

npm i https://pkg.pr.new/vue-i18n@2158 

@intlify/vue-i18n-core

npm i https://pkg.pr.new/@intlify/vue-i18n-core@2158 

commit: 798e28c

@kazupon kazupon requested a review from Copilot April 5, 2025 17:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/vue-i18n-core/src/types.ts:19

  • Changing the module augmentation comment from '@intlify/vue-i18n-core' to '@intlify/core-base' may disrupt existing augmentations. Please verify that consumers update their augmentation targets accordingly.
+ * declare module '@intlify/core-base' { 

packages/vue-i18n-core/src/types.ts:26

  • Re-exporting GeneratedTypeConfig instead of declaring an interface could impact module augmentation functionality. Please ensure that this change fully supports the intended augmentation behavior.
export { GeneratedTypeConfig } 
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazupon kazupon merged commit 6ea7900 into intlify:v11 Apr 5, 2025
24 checks passed
Blankll added a commit to geek-fun/dockit that referenced this pull request Jun 29, 2025
![snyk-top-banner](https://res.cloudinary.com/snyk/image/upload/r-d/scm-platform/snyk-pull-requests/pr-banner-default.svg) <h3>Snyk has created this PR to upgrade vue-i18n from 11.1.3 to 11.1.5.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **2 versions** ahead of your current version. - The recommended version was released **23 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>vue-i18n</b></summary> <ul> <li> <b>11.1.5</b> - <a href="https://redirect.github.com/intlify/vue-i18n/releases/tag/v11.1.5">2025-05-27</a></br> <h2>What's Changed</h2> <h3>🐛 Bug Fixes</h3> <ul> <li>fix: n() &amp; d() output depending "part" option by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3094215294" data-permission-text="Title is private" data-url="intlify/vue-i18n#2194" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/2194/hovercard" href="https://redirect.github.com/intlify/vue-i18n/pull/2194">#2194</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/intlify/vue-i18n/compare/v11.1.4...v11.1.5"><tt>v11.1.4...v11.1.5</tt></a></p> </li> <li> <b>11.1.4</b> - <a href="https://redirect.github.com/intlify/vue-i18n/releases/tag/v11.1.4">2025-05-24</a></br> <h2>What's Changed</h2> <h3>🌟 Features</h3> <ul> <li>feat: Part options support $n by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mauryapari/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/mauryapari">@ mauryapari</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3024470517" data-permission-text="Title is private" data-url="intlify/vue-i18n#2175" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/2175/hovercard" href="https://redirect.github.com/intlify/vue-i18n/pull/2175">#2175</a></li> <li>feat: Part options support $d by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mauryapari/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/mauryapari">@ mauryapari</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3033381479" data-permission-text="Title is private" data-url="intlify/vue-i18n#2180" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/2180/hovercard" href="https://redirect.github.com/intlify/vue-i18n/pull/2180">#2180</a></li> </ul> <h3>⚡ Improvement Features</h3> <ul> <li>fix: support vue core internal slot key changing by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3088311153" data-permission-text="Title is private" data-url="intlify/vue-i18n#2190" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/2190/hovercard" href="https://redirect.github.com/intlify/vue-i18n/pull/2190">#2190</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/intlify/vue-i18n/compare/v11.1.3...v11.1.4"><tt>v11.1.3...v11.1.4</tt></a></p> </li> <li> <b>11.1.3</b> - <a href="https://redirect.github.com/intlify/vue-i18n/releases/tag/v11.1.3">2025-04-05</a></br> <h2>What's Changed</h2> <h3>🐛 Bug Fixes</h3> <ul> <li>fix: cannot resolve the ast messages which has json path for v11 by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kazupon/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/kazupon">@ kazupon</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2974370720" data-permission-text="Title is private" data-url="intlify/vue-i18n#2159" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/2159/hovercard" href="https://redirect.github.com/intlify/vue-i18n/pull/2159">#2159</a></li> </ul> <h3>⚡ Improvement Features</h3> <ul> <li>fix: duplicate generated type config naming by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/BobbieGoede/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/BobbieGoede">@ BobbieGoede</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2974358462" data-permission-text="Title is private" data-url="intlify/vue-i18n#2158" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/2158/hovercard" href="https://redirect.github.com/intlify/vue-i18n/pull/2158">#2158</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/intlify/vue-i18n/compare/v11.1.2...v11.1.3"><tt>v11.1.2...v11.1.3</tt></a></p> </li> </ul> from <a href="https://redirect.github.com/intlify/vue-i18n/releases">vue-i18n GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhNmY5OGU3NC03MDNhLTQ5ZmMtOWQzMi0zMmQ3NjhkMTkzY2YiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImE2Zjk4ZTc0LTcwM2EtNDlmYy05ZDMyLTMyZDc2OGQxOTNjZiJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?pkg&#x3D;vue-i18n&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"vue-i18n","from":"11.1.3","to":"11.1.5"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"a6f98e74-703a-49fc-9d32-32d768d193cf","prPublicId":"a6f98e74-703a-49fc-9d32-32d768d193cf","packageManager":"npm","priorityScoreList":[],"projectPublicId":"d19c39b4-9b25-4232-b09a-2d71e94c8a24","projectUrl":"https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":2,"publishedDate":"2025-05-27T15:58:37.419Z"},"vulns":[]}' Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Improvement Includes backwards-compatible fixes

2 participants