Skip to content

deps: update brotli to 1.1.0#50804

Merged
nodejs-github-bot merged 1 commit intomainfrom
actions/tools-update-brotli
Dec 27, 2023
Merged

deps: update brotli to 1.1.0#50804
nodejs-github-bot merged 1 commit intomainfrom
actions/tools-update-brotli

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Nov 19, 2023

This is an automated update of brotli to 1.1.0.
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. brotli Issues and PRs related to the brotli dependency. needs-ci PRs that need a full CI run. labels Nov 19, 2023
@targos targos force-pushed the actions/tools-update-brotli branch from a6ad5ec to e521913 Compare December 23, 2023 10:57
@targos
Copy link
Member

targos commented Dec 23, 2023

Just rebased, fixed the conflict and updated the gyp file.
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Dec 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56474/
lpinca
lpinca approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5e64483 into main Dec 27, 2023
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-brotli branch December 27, 2023 06:29
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Dec 27, 2023

Landed in 5e64483
@isker
Copy link
Contributor

isker commented Dec 27, 2023

Clueless question from the peanut gallery: is this kind of change typically okay to backport to LTS? We have some compression-intensive workloads on 20.x where the supposed ~5% performance improvement included in this upgrade would be appreciated.
@lpinca
Copy link
Member

lpinca commented Dec 27, 2023

is this kind of change typically okay to backport to LTS?

Yes, it will be backported.
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@nodejs-github-bot @RafaelGSS
deps: update brotli to 1.1.0
f00f120 
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
This was referenced Jan 4, 2024
Closed
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jan 7, 2024
@richardlau
tools: fix version parsing in brotli update script
15b38fa 
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@richardlau @marco-ippolito
tools: fix version parsing in brotli update script
c63f465 
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: nodejs#51373 Refs: nodejs#50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@richardlau @Medhansh404
tools: fix version parsing in brotli update script
54cda22 
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: nodejs#51373 Refs: nodejs#50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@richardlau @targos
tools: fix version parsing in brotli update script
29492e2 
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@nodejs-github-bot @richardlau
deps: update brotli to 1.1.0
0afeede 
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
tools: fix version parsing in brotli update script
d460750 
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@nodejs-github-bot @richardlau
deps: update brotli to 1.1.0
7d60877 
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
tools: fix version parsing in brotli update script
4ce2ecb 
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
aduh95 pushed a commit that referenced this pull request Nov 3, 2024
@nodejs-github-bot @aduh95
deps: update brotli to 1.1.0
96ec48d 
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

brotli Issues and PRs related to the brotli dependency. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

4 participants

@nodejs-github-bot @targos @isker @lpinca