crypto: reject dh,x25519,x448 in {Sign,Verify}Final#53774
Merged
nodejs-github-bot merged 6 commits intonodejs:mainfrom Sep 6, 2024
Merged
crypto: reject dh,x25519,x448 in {Sign,Verify}Final#53774nodejs-github-bot merged 6 commits intonodejs:mainfrom
nodejs-github-bot merged 6 commits intonodejs:mainfrom
Conversation
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #53742
In this PR we handle the return value of
EVP_PKEY_{sign,verify}_init, when it returns-2, we throw theERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPEerror. This approach is future proof as we don't have to maintain a list of key types that can not be used with signing / verifying.