docs: clarify UndiciHeaders validation guidance#4832
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #4832 +/- ## ========================================== + Coverage 93.19% 93.20% +0.01% ========================================== Files 109 109 Lines 34222 34222 ========================================== + Hits 31893 31897 +4 + Misses 2329 2325 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95 approved these changes Feb 17, 2026
Uzlopak approved these changes Feb 19, 2026
Contributor
Uzlopak left a comment
There was a problem hiding this comment.
This is important, but I fear people will not notice it. I think we should put it into a warning box, if possible
Ethan-Arrowood approved these changes Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- clarify that Undici performs protocol-level header syntax validation\n- document that callers must validate and sanitize user-provided header names and values\n- document that in the string[] header format, only indexed array elements are processed and extra array object properties are ignored\n\n## Testing\n- npm run lint