Add helper class to capture context using ScheduledExecutorService

[ammachado]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (18d192d) to head (6db18c5).
Report is 42 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@ ## main #6712 +/- ## ============================================ - Coverage 90.09% 90.01% -0.08%  - Complexity 6390 6482 +92  ============================================ Files 711 719 +8 Lines 19333 19585 +252 Branches 1891 1931 +40 ============================================ + Hits 17418 17630 +212  - Misses 1335 1355 +20  - Partials 580 600 +20 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jkwatson]

This is a good idea. This PR needs some more testing, as there are bunch of uncovered methods in the implementation.

[shalk]

private field in CurrentContextScheduledExecutorService.java can be removed

[shalk]

Suggested change

	private final ScheduledExecutorService delegate;
	CurrentContextScheduledExecutorService(ScheduledExecutorService delegate) {
	super(delegate);
	this.delegate = delegate;
	}
	CurrentContextScheduledExecutorService(ScheduledExecutorService delegate) {
	super(delegate);
	}

[shalk]

Suggested change

	return delegate.schedule(Context.current().wrap(command), delay, unit);
	return ((ScheduledExecutorService) delegate())
	.schedule(Context.current().wrap(command), delay, unit);

[jkwatson]

I think I prefer just keeping a local copy of the delegate rather than having to make this cast everywhere.

[shalk]

Suggested change

	return delegate.schedule(Context.current().wrap(callable), delay, unit);
	return ((ScheduledExecutorService) delegate())
	.schedule(Context.current().wrap(callable), delay, unit);

[shalk]

Suggested change

	return delegate.scheduleAtFixedRate(command, initialDelay, period, unit);
	return ((ScheduledExecutorService) delegate())
	.scheduleAtFixedRate(command, initialDelay, period, unit);

[shalk]

Suggested change

	return delegate.scheduleWithFixedDelay(command, initialDelay, delay, unit);
	return ((ScheduledExecutorService) delegate())
	.scheduleWithFixedDelay(command, initialDelay, delay, unit);