Allow censoring Categorical distributions #7662
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@ ## main #7662 +/- ## ======================================= Coverage 92.92% 92.92% ======================================= Files 107 107 Lines 18299 18308 +9 ======================================= + Hits 17004 17013 +9 Misses 1295 1295
🚀 New features to boost your workflow:
|
jessegrabowski left a comment
jessegrabowski left a comment There was a problem hiding this comment.
Add a test for the logcdf?
pymc/distributions/discrete.py Outdated
There was a problem hiding this comment.
I don't love making _safe_index_value_p a method. What's the conceptual advantage vs just being a function?
There was a problem hiding this comment.
doesn't clutter the namespace, that's the only difference
I did... it's in the Censored. Since there is no Categorical scipy distribution, I would just be comparing two implementations written by me? |
| Ah, I tested the logp... hmm okay okay |
ricardoV94 force-pushed the censored_cat branch from a3cbfee to 60c763f Compare 
| ) | ||
| | ||
| def test_categorical_logp_batch_dims(self): | ||
| check_selfconsistency_discrete_logcdf( |
There was a problem hiding this comment.
This tests the logcdf
2 participants
Reported missing functionality in https://discourse.pymc.io/t/how-to-setup-a-censored-orderedlogistic-model/16451
📚 Documentation preview 📚: https://pymc--7662.org.readthedocs.build/en/7662/