Skip to content

Replace black and isort with ruff#23

Merged
egeakman merged 1 commit intomainfrom
ruff
Jun 7, 2025
Merged

Replace black and isort with ruff#23
egeakman merged 1 commit intomainfrom
ruff

Conversation

@egeakman
Copy link
Member

@egeakman egeakman commented Jun 2, 2025

Closes #21

@egeakman egeakman self-assigned this Jun 2, 2025
@egeakman egeakman requested review from hugovk and rffontenelle June 3, 2025 07:49
@egeakman egeakman merged commit bf0b8ea into main Jun 7, 2025
56 checks passed
@egeakman egeakman deleted the ruff branch June 7, 2025 19:48
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review (I was travelling last week): looks good :)

Only suggestions I would have made:

  • keep check-toml
  • put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note at https://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using --fix
  • move the Ruff args out of pre-commit config and into pyproject.toml, so they are available when running Ruff outside of pre-commit

But not a big deal.

@egeakman
Copy link
Member Author

egeakman commented Jun 8, 2025

Post-merge review (I was travelling last week): looks good :)

Only suggestions I would have made:

  • keep check-toml
  • put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note at https://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using --fix
  • move the Ruff args out of pre-commit config and into pyproject.toml, so they are available when running Ruff outside of pre-commit

But not a big deal.

Thank you! Created a new issue (#24) to track these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants