Avoid cloning empty Annotation array in TypeDescriptor #32405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rework AnnotatedElementAdapter to avoid cloning the underlying Annotation array if it is empty when getAnnotations is called. Additionally, make the class static and add a factory method that returns a singleton instance for null or empty Annotation arrays.
spring-projects-issues added the status: waiting-for-triage 
sbrannen added in: core sbrannen added a commit that referenced this pull request Mar 10, 2024
Member
sbrannen changed the title Annotation array in TypeDescriptor 
jhoeller added for: backport-to-6.0.x status: backported jhoeller added a commit that referenced this pull request Mar 16, 2024
jhoeller added a commit that referenced this pull request Mar 16, 2024
jhoeller added a commit that referenced this pull request Mar 16, 2024
Yangushan pushed a commit to Yangushan/spring-framework that referenced this pull request Mar 17, 2024
Contributor
| Backported to 6.1.6, 6.0.19, 5.3.34 as well now since it is a straightforward internal optimization in a hot code path. |
jhoeller added a commit that referenced this pull request Mar 17, 2024
jhoeller added a commit that referenced this pull request Mar 17, 2024
jhoeller added a commit that referenced this pull request Mar 17, 2024
jhoeller added a commit that referenced this pull request Mar 17, 2024
Yangushan pushed a commit to Yangushan/spring-framework that referenced this pull request Mar 18, 2024
Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rework
AnnotatedElementAdapterto avoid cloning the underlyingAnnotationarray if it is empty whengetAnnotations()is called.Additionally, make the class static and add a factory method that returns a singleton instance for
nullor an emptyAnnotationarrays.