Improve HttpServiceMethod support for Kotlin suspending functions returning Flow #35718
+18 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Sulman <dmitry.sulman@gmail.com>
spring-projects-issues added the status: waiting-for-triage 
sdeleuze added in: web 
Contributor
| Fixed via d0ff8f9 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In #35473 (comment) it was noted that the HTTP Interface does not support Kotlin suspending functions returning
Flow.While this technically works, the issue is that such invocations are handled via
ReactorHttpExchangeAdapter#exchangeForBodyMonoinstead ofReactorHttpExchangeAdapter#exchangeForBodyFlux.This PR fixes the issue by adapting
HttpServiceMethodin a similar way to the improvements made toRSocketServiceMethodin #35473.cc @sdeleuze