Do not extract candidates containing JS string interpolation pattern ${#17142
Merged
RobinMalfait merged 3 commits intomainfrom Mar 12, 2025
Merged
Do not extract candidates containing JS string interpolation pattern ${#17142RobinMalfait merged 3 commits intomainfrom
${#17142RobinMalfait merged 3 commits intomainfrom
Conversation
b44653f to ba9f14e Compare If this occurs inside of strings then it's fine but everywhere else it's thrown out. Technically you can set it in the value of a CSS variable, but I think guarding against that is only needed if somebody actually runs into problems with this.
823d4f4 to 3e5fe97 Compare Contributor
| @RobinMalfait Here's another issue that is resolved by this I think: #15853 |
thecrypticace approved these changes Mar 12, 2025
This was referenced Mar 12, 2025
ilievmart added a commit to 42dotmk/KlimentOhridski that referenced this pull request Mar 20, 2025
This also fixes <ol> and <ul> tag rendering which broke in today's dependency update. Related: tailwindlabs/tailwindcss#17142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where often people run into issues where they try to use string interpolation and it doesn't work. Even worse, it could result in crashes because we will actually generate CSS. This fix only filters out candidates with a pattern like
${. If this occurs in a string position it is fine.Another solution would be to add a pre processor for JS/TS (and all thousand file extension combinations) but the problem is that you can also write JS in HTML files so we would have to pre process HTML as well which would not be ideal.
Test plan
Given this input:
This is the result:
Fixes: #17054
Fixes: #15853