Skip to content

Extract keyframe name when followed by comma#17352

Merged
philipp-spiess merged 2 commits intomainfrom
fix/keyframe-emit
Mar 24, 2025
Merged

Extract keyframe name when followed by comma#17352
philipp-spiess merged 2 commits intomainfrom
fix/keyframe-emit

Conversation

@philipp-spiess
Copy link
Contributor

@philipp-spiess philipp-spiess commented Mar 24, 2025

Fixes #17332

This PR ensures that keyframes are emitted even when they are referenced following a comma, e.g.:

@theme { --animate-test: 500ms both fade-in, 1000ms linear 500ms spin infinite; /* ^ */ @keyframes fade-in { from { opacity: 0%; } to { opacity: 100%; } } }

Test plan

Added a unit test to capture the issue from #17332

@philipp-spiess philipp-spiess requested a review from a team as a code owner March 24, 2025 11:06
@philipp-spiess philipp-spiess merged commit e8715d0 into main Mar 24, 2025
6 checks passed
@philipp-spiess philipp-spiess deleted the fix/keyframe-emit branch March 24, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants