Fix drop shadow filters with multiple shadows#17515
Merged
thecrypticace merged 4 commits intomainfrom Apr 3, 2025
Merged
Conversation
thecrypticace force-pushed the fix/multiple-drop-shadow-filters branch from 4ff0ff9 to 5f9bd8f Compare Contributor
philipp-spiess left a comment
philipp-spiess left a comment There was a problem hiding this comment.
Change LGTM but let's make sure to add an example for this to the UI specs for shadows I think
philipp-spiess approved these changes Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that I broke support for multiple drop-shadow filters when
@theme inlinewas used in v4.1. This PR fixes that by segmenting the drop shadow value on top-level commas and wrapping each segment withdrop-shadow(…)like we did in v4.0.