Skip to content

fix(perf): address slow parse when using unknown-options-as-args#394

Merged
bcoe merged 5 commits intomainfrom
fix-386
Jun 20, 2021
Merged

fix(perf): address slow parse when using unknown-options-as-args#394
bcoe merged 5 commits intomainfrom
fix-386

Conversation

@bcoe
Copy link
Member

@bcoe bcoe commented Jun 20, 2021

@robmcl4 the recommended regex replacements in #386 don't quite work, because of the case of:

----------foo-bar-snuh.

Instead I now capture and truncate a large number of leading -.

Fixes #386

@bcoe
Copy link
Member Author

bcoe commented Jun 20, 2021

@robmcl4 feel free to recommend additional test cases, this seemed to catch the examples you provided.

@bcoe bcoe changed the title fix(perf): address slow perf when using unknown-options-as-args fix(perf): address slow parse when using unknown-options-as-args Jun 20, 2021
@bcoe bcoe merged commit 441f059 into main Jun 20, 2021
@bcoe bcoe deleted the fix-386 branch June 20, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant