fix: rewrite isUnknownOption as stripped down full parse#507
Closed
shadowspawn wants to merge 2 commits intoyargs:mainfrom
Closed
fix: rewrite isUnknownOption as stripped down full parse#507shadowspawn wants to merge 2 commits intoyargs:mainfrom
shadowspawn wants to merge 2 commits intoyargs:mainfrom
Conversation
Member Author
| I was frustrated by ongoing issues with Wanted to post the work in case useful to look at again in future. I think a full rewrite is too much churn for now so I'll close PR. |
Member Author
| I liked the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a lot of issues related to
unknown-options-as-args. I had a look at rewritingisUnknownOptionbased directly on the full parser to see how much code was needed to do "real" parsing. Not too bad. (Alternative PRs coming with lighter weight approach, patching the existing code!)Open Issues: #312 #359 #376 #501
Closed Issues: #226 #231 #386 #437 #453
Open Pull Requests: #502
Closed Pull Requests #207 #227 #238 #326 #386 #394 #400 #438 #456 #458