C++ int to string conversion

Question

Current source code:

string itoa(int i) { std::string s; std::stringstream out; out << i; s = out.str(); return s; } class Gregorian { public: string month; int day; int year; //negative for BC, positive for AD // month day, year Gregorian(string newmonth, int newday, int newyear) { month = newmonth; day = newday; year = newyear; } string twoString() { return month + " " + itoa(day) + ", " + itoa(year); } };

And in my main:

Gregorian date = new Gregorian("June", 5, 1991); cout << date.twoString();

I'm getting this error:

mayan.cc: In function ‘int main(int, char**)’: mayan.cc:109:51: error: conversion from ‘Gregorian*’ to non-scalar type ‘Gregorian’ requested

Does anyone know why int to string conversion is failing in here? I'm fairly new to C++ but am familiar with Java, I've spent a good deal of time looking for a straightforward answer to this problem but am currently stumped.

You can get rid of std::string s; in itoa and just return out.str();. The return string will be constructed before the stringstream is destroyed. Reasonable compilers will likely produce the exact same code in both cases, but the extra temporary tends to suggest to people looking at your code that you don't understand or trust the C++ scoping rules. — David Schwartz
– David Schwartz, Commented Apr 23, 2012 at 20:04
Unrelated, but did you mean to name the function toString()? — Neil
– Neil, Commented Apr 23, 2012 at 20:09
Coming from Java, I didn't know if C++ already had a toString() method. I didn't want to overload it if I didn't need to. — Sam Meow
– Sam Meow, Commented Apr 23, 2012 at 20:12

juanchopanza · Accepted Answer · 2012-04-23 20:02:13Z

15

You are assigning a Gregorian pointer to a Gregorian. Drop the new:

Gregorian date("June", 5, 1991);

answered Apr 23, 2012 at 20:02

juanchopanza

228k35 gold badges421 silver badges493 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sam Meow Over a year ago

Wow, that was an incredibly fast response. A big thank you for such a simple solution.

juanchopanza Over a year ago

@SamMeow no problem. If the answer is OK then you can select it as such.

dodo · Accepted Answer · 2019-04-01 16:18:38Z

You can use this function to convert int to string, after including sstream:

#include <sstream> string IntToString (int a) { stringstream temp; temp<<a; return temp.str(); }

Collectives™ on Stack Overflow

C++ int to string conversion

2 Answers 2

2 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Related