Handling Runtime exception in Java

Question

I have the following piece of code

 try{//do something } catch (Exception e) { log.error(e, e); if (e instanceof RuntimeException) { throw (RuntimeException) e; } else { throw new RuntimeException(e); } }

the findbugs stataic analysis tool throws this warning on it

instanceof will always return true for all nonnull values in methodX, since all RuntimeException are instances of RuntimeException

what i dont understand is that its Exception which is being caught and not the RuntimeException, so why this warning ?

Alexander Pavlov · Accepted Answer · 2012-05-23 10:00:39Z

Perhaps, the // do something code does not throw any checked exception, so the only exceptions you can get in your try-block are unchecked ones (subclassing RuntimeException).

Daniel Engmann · Accepted Answer · 2012-05-23 10:08:03Z

You could also try following code. This will be better to read and maintain.

try{//do something } catch (RuntimeException e) { throw e; } catch (Exception e) { throw new RuntimeException(e); }

anstarovoyt · Accepted Answer · 2012-05-23 10:04:05Z

Probably there is no methods that throws not RuntimeException in "try" part. Therefore, you can use construction

catch(RuntimeException e) { //Do something }

gyorgyabraham · Accepted Answer · 2012-10-03 15:18:52Z

Try http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/base/Throwables.html#propagate%28java.lang.Throwable%29. It does exactly what you want. Today I did the replacement for the same reason (findbugs warning), also looked the source of this method.

Collectives™ on Stack Overflow

Handling Runtime exception in Java

4 Answers 4

Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Linked

Related