We have a lot of old unit tests which were written with Junit 3.x. I am tasked with porting them to our JUnit 4.x coding standard, which among things, forbids the use of "extends TestCase".
Some of the old tests have a call to super.setUp() which I need to now remove, however, I am not sure what is happening in that call. Can I just delete this line of code without worrying or should I replace it with something?
Since setUp() is now called before each test, you can safely remove super.setUp().
junit.framework.TestCase, and that base class has a non-abstract setUp() call then the call to super.setUp() is absolutely necessary. If you have base classes after porting to JUnit4 (and with Rules they are seldom needed) then make the @Before and @After methods have good names and make them final.Comment out the line and then run the test. If the test was written right the test result should give you the answer assuming the test was succeeding previously.
super.setUp() is TestCase doesn't do anything and can be safely removed. You still need to keep the super.setUp() call if you are extending another class. However that one won't fail to compile, so you should be ok.
For example, suppose we have ATest extends BTest and BTest extends TestCase. You can safely remove the super.setUp() call from BTest and not ATest. Since the BTest one might do something, ATest still needs to call it.
