Parse a file name from char * variable

Question

I have a value in character pointer variable and the value is changed dynamically.

for e.g

one case: char *ptr = sometext || abc.txt; second case: char *ptr = abc.txt || sometext;

I need only file name in another variable. str = abc.txt

currently I am using the code:

CString str; char* lpszToToken = stLine.GetBuffer(stLine.GetLength()); char* lpszToken = strtok(lpszToToken, "|"); while(lpszToken != NULL) { lpszToken = strtok(NULL, "|"); str = lpszToken; }

but it working in only first case: I need a genric code to run in both case Any idea? Thanks,

Community · Accepted Answer · 2017-05-23 12:29:00Z

My C is rusty, but why not something like:

char* fname = strtok( fileNames, "|"); while (fname != NULL) { // do something with the file here.. processFile( fname); fname = strtok( NULL, "|"); // next. }

Also, Hungarian notation is a horrible way to program. It effectively conceals & obfuscates most meaning, rendering clear and simple problems opaque & ugly. See how readable my example is, compared with the gack you supplied?

Your instructor (and Petzold) were very unfortunately mistaken to be teaching this to you. I suggest writing "literate" code instead.

See:

@sasha.sochka Please provide a rationale/link for this kind of general statements.
If my opinion was somewhere counted I would vote that strtok is the worst designed function for ever (in C)
I agree with Sasha. Hidden global state (worse than using global variables, since it is opaque), unclear API design & security issues. stackoverflow.com/questions/5999418/… But hey, I used it when I was a newbie too.

ScottMcP-MVP · Accepted Answer · 2013-07-15 13:28:58Z

0

Since you have CString available you can use CString::Find or CString::Tokenize

answered Jul 15, 2013 at 13:28

ScottMcP-MVP

10.5k2 gold badges17 silver badges15 bronze badges

Collectives™ on Stack Overflow

Parse a file name from char * variable

2 Answers 2

3 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Linked

Related