if condition not working in the expected manner

Question

the current page is getting the variables item and code from query string,so according to my code it should go into any of the first three conditions... but its going into the last else conditon.. while echoing the values $a and $i, i am getting 2 and A-1-1 respectively.

$a=$_GET['code']; $i=$_GET['item']; if($a==1 && $i!='') { header("location:http//:www.abc.com"); } else if($a==2 && $i!='') { header("location:http://www.xyz.com"); } else if($a==3 && $i!='') { header("location:http://www.xpqr.com"); } else if($a==1) { header("location: http://www.a1bc.com"); } else if($a==2) { header("location:http://www.x1yz.com"); } else if($a==3) { header("location:http://www.x1pqr.com"); } else { echo "ERROR"; }

can someone help me find the issue why the if else not working in the expected manner.

You're assigning $a = 1 instead of comparing $a == 1. You can use Yoda conditions to avoid this problem: 1 == $a. 1 = $a will throw an error. — insertusernamehere
– insertusernamehere, Commented Aug 14, 2013 at 7:00
Sorry that was an error while posting..!still the problem persist.. — thejus_r
– thejus_r, Commented Aug 14, 2013 at 7:02
Mahavir Munot is just trolling. <> is the same as != as descibed here. I wish I had a minus on that answer... — machineaddict
– machineaddict, Commented Aug 14, 2013 at 7:10

Suresh Kamrushi · Accepted Answer · 2013-08-14 06:59:19Z

1

In conditions you are writing

if($a=1 && $i!='') // "=" is assignment operator

it should bt

if($a==1 && $i!='')

answered Aug 14, 2013 at 6:59

Suresh Kamrushi

16.2k13 gold badges79 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ibu · Accepted Answer · 2013-08-14 06:59:15Z

you need to use the equality operator: == double equal

if($a==1 && $i!='')

single equal is the assignment operator.

heretolearn · Accepted Answer · 2013-08-14 07:03:27Z

You are using assignment operator instead of a conditional operator. For the above code the value of a will always be 1 because of the following line of code :

if($a=1 && $i!='')

= is an assignment operator where as == is a conditional operator.

Use == in all your if condition.

Hope this will help.

Konsole · Accepted Answer · 2013-08-14 07:04:03Z

Use == in all your if condition. And your header codes

header("location: http:www.abc.com");

Should be like this

header("location: http://www.abc.com"); // you are missing '//' in every header

Dante Ditan · Accepted Answer · 2013-08-14 07:22:28Z

 $a=$_GET['code']; $i=$_GET['item']; if($a==1 && !$i) { header("location:http//:www.abc.com"); } else if($a==2 && !$i) { header("location:http://www.xyz.com"); } else if($a==3 && !$i) { header("location:http://www.xpqr.com"); } else if($a==1) { header("location: http://www.a1bc.com"); } else if($a==2) { header("location:http://www.x1yz.com"); } else if($a==3) { header("location:http://www.x1pqr.com"); } else { echo "ERROR"; }

use !$i it sets to false.

Collectives™ on Stack Overflow

if condition not working in the expected manner

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Related