C# && , || Operators

Question

I have some values from MySQL . and I want to know ... how I can do the following :

if (Value.ToString() == "1" || Value.ToString() == "2" || Value.ToString() == "3" && SecondValue.ToString() == "5")

Value can be : 1 "or" 2 "or" 3 ... and Second Value "5" . means One of (the three "Value") && SecondValue . or there is no way to do that ? and I should just do this :

if (Value.ToString() == "1" && SecondValue.ToString() == "5" { } if (Value.ToString() == "2" && SecondValue.ToString() == "5" { } ect ....

Thank you for your answer .

I would prevent calling a method more than once if you don't need to. I'm talking about ToString(), in this case it could be harmless, but you'd rather want to buffer it in another variable. — Silvermind
– Silvermind, Commented Oct 17, 2013 at 18:09

Claudio Redi · Accepted Answer · 2013-10-17 17:56:39Z

Your code is almost correct but you need to add an extra parenthesis around the "or" conditions to group them.

if ((Value.ToString() == "1" || Value.ToString() == "2" || Value.ToString() == "3") && SecondValue.ToString() == "5")

Captain Skyhawk · Accepted Answer · 2013-10-17 17:57:15Z

2

I think what you're trying to go for is this:

 if (new List<string>() { "1", "2", "3" }.Contains(Value.ToString()) && SecondValue.ToString() == "5")

answered Oct 17, 2013 at 17:57

Captain Skyhawk

3,4902 gold badges27 silver badges39 bronze badges

1 Comment

Franck Over a year ago

+1 for more versatility but i would change the List for basic Array. I don't need a 12' Truck to transport a microwave.

Krekkon · Accepted Answer · 2013-10-17 17:57:59Z

Try this, it is clean enugh:

if (SecondValue.ToString() == "5") { if (Value.ToString() == "1" || Value.ToString() == "2" || Value.ToString() == "3") { //Do Stuff } }

Regards, Krekkon

Thanks to all :p first answer was what I needed .I was looking for

Preston Guillot · Accepted Answer · 2013-10-17 17:58:38Z

You can use parenthesis to group your boolean conditions however you want. If you want a case where "one of these cases is true and also one of these other cases is true", group the cases appropriately. In your case, you'd be better off using a collection to hold your values for valid cases for "Value", something like:

var myValue = Value.ToString(); var myValidCases = new [] {"1", "2", "3"}; if(myValidCases.Any(validCase => validCase == myValue) && SecondValue.ToString() == "5") { //do something }

Giannis Paraskevopoulos · Accepted Answer · 2013-10-17 17:56:30Z

if ( ( Value.ToString() == "1" || Value.ToString() == "2" || Value.ToString() == "3" ) && SecondValue.ToString() == "5" )

System Down · Accepted Answer · 2013-10-17 17:57:01Z

Here's what it looks like basically:

(Value == 1 && SecondValue == 5) || (Value == 2 && SecondValue == 5) || (Value == 3 && SecondValue == 5)

Now the && operator is very much like the multiplication operator in that it is distributive. Which means we can do this:

(Value == 1 || Value == 2 || Value == 3) && SecondValue == 5

Collectives™ on Stack Overflow

C# && , || Operators

6 Answers 6

Comments

1 Comment

1 Comment

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

1 Comment

1 Comment

Comments

Comments

Comments

Related