Clarification on java pass-by-value

Question

I'm confused as to why the following code doesn't change the data of the Node a:

public class Node{Node next; int data;} public static void change(Node a) { a = a.next; } public static void main(String [] args){ Node a = new Node(); Node b = new Node(); a.next = b; a.data = 1; b.next = null; b.data = 2; change(a); System.out.print(a.data); //Still 1, why isn't it changed to 2? }

Since Node is an object, isn't its reference passed by value to the method change? Which means any changes made to the passed in Node should actually change the node?

I'm sure there is a duplicate or two [hundred] .. like stackoverflow.com/questions/40480/… or stackoverflow.com/questions/7893492/… — user2864740
– user2864740, Commented Oct 20, 2013 at 6:25
(The above code doesn't work precisely because Java is Call by Value - reassignment of parameters does not affect the variables/bindings in the caller.) — user2864740
– user2864740, Commented Oct 20, 2013 at 6:26
I'm trying to understand argument passing in java, not actually trying to achieve some function — SKLAK
– SKLAK, Commented Oct 20, 2013 at 6:26

noone · Accepted Answer · 2013-10-21 04:22:56Z

This is because in Java you call methods via reference-copies.

This means that when you call change(a); Java basically creates a copy of the reference a and this will be the incoming parameter in public static void change(Node a). Inside the method you will then change that copied reference to point somewhere else. And this will have no effect once your method returns.

This exact same code will work though without the method in between.

Do this a = a.next; instead of change(a) and now your a.data will be 2.

"creates a copy of the reference to a " No. a is a reference (it is a variable of reference type). There cannot be a "reference to a".
@newacct I think it is quite obvious that I meant a reference to the object in memory which humans refer to as a, and not a reference to the reference... but I edited it and removed the "to".

Stephan · Accepted Answer · 2013-10-20 06:22:52Z

Your change method does an empty assignment. The variable a is set to the next node but not returned from the method. The change will only be available inside the method scope. You could change that:

public static Node change(Node a) { return a.next; }

And call it with:

a = change(a); System.out.print(a.data);

Anirudha · Accepted Answer · 2013-10-20 06:29:42Z

With

public static void change(Node a)

a is not an alias but a new variable containing the address of the paramerter passed..

So,

a.data=100;//would change value of the actual Node in main [NewVariableWithAddressOfa].data=100;

But when you do

a = a.next; [NewVariableWithAddressOfa]=[NewVariableWithAddressOfa].next;

you are assigning the address of b which won't change the original Node a since as I said earlier a in change method is a new variable!

Pignic · Accepted Answer · 2013-10-20 07:26:36Z

The operator = change the reference of "a". Use a method "set(Node nodeToCopy)" That will copy all the "nodeToCopy" in the current node.

public class Node{ Node next; int data; public void set(Node Other) { next = other.next; data = other.data; } } public static void change(Node a) { a.set(a.next); }

BUT !!! It not that you want to do because, it will break your objects a and b. You have no others solution :

Node a = new Node(); Node b = new Node(); Node i = a; a.next = b; a.data = 1; b.next = null; b.data = 2; System.out.print(i.data); //it's 1 i = i.next; System.out.print(i.data); //it's 2

Community · Accepted Answer · 2020-06-20 09:12:55Z

Refer to Call by Value for why the assignment to the parameter did not (and will not) alter the variable bindings in the caller:

.. In call-by-value, the argument expression is evaluated, and the resulting value is bound to the corresponding variable in the function .. If the function or procedure is able to assign values to its parameters, only its local copy is assigned - that is, [any variable used as an argument for] a function call is unchanged in the caller's scope when the function returns.

Call-by-value is not a single evaluation strategy, but rather the family of evaluation strategies in which a function's argument is evaluated before being passed to the function ..

Pay attention to the different terms variable, arguments, and parameter above which have been purposefully used. An object that is mutated is, well, changed everywhere - which is consistently describable by Call by [Object] Sharing; this, however, is orthogonal to Call by Value.

i don't know why people downvote without comments. this is an intelligent answer, esp. in its mention of "call by sharing"

Collectives™ on Stack Overflow

Clarification on java pass-by-value

5 Answers 5

2 Comments

Comments

Comments

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

1 Comment

Linked

Related