Adding class to jQuery object that has been passed to a function

Question

I have a simple jQuery function that adds a class (.dataerror) to various html elements if they are empty. First, I'm doing this:

$('.editable').each(function() { if (!$(this).html()) { showerror($(this)); } });

And a super-simplified version of the function looks like this:

function showerror(element) { $(element).addClass('dataerror'); }

However, this DOES NOT add the class to the elements if they are empty.

If I change the function to:

function showerror(element){ $(element).hide(); }

...then the elements ARE hidden as expected if they are empty.

Can anyone tell my why .addClass() DO NOT work on the element in this context, while other methods such as .hide() DO work?

Thx.

what element types are you adding the ".editable" class to?

hammus
– hammus

2013-11-10 20:49:37 +00:00
Commented Nov 10, 2013 at 20:49 — hammus
– hammus, Commented Nov 10, 2013 at 20:49

abhiklpm · Accepted Answer · 2013-11-10 20:49:52Z

1

Instead of

$(element).addClass('dataerror');

can u try

element.addClass('dataerror');

answered Nov 10, 2013 at 20:49

abhiklpm

1,6532 gold badges16 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Contention Over a year ago

Yep, you have that working as expected there, but I can't get it to work here. Some jQuery methods like .hide() work but I can't get .addClass() to work. Weird. I need to look into the rest of my code. :o)

abhiklpm Over a year ago

what version of jquery u use? checking in which browser ?

Contention Over a year ago

1.10.2 and latest Chrome & Safari on Mavericks.

Contention Over a year ago

I'm also running a couple of jQuery plugins which may be screwing things up here.

abhiklpm Over a year ago

after $(element).addClass('dataerror'); can u add alert(element.attr('class')); and check

|

Lim H. · Accepted Answer · 2013-11-10 20:49:55Z

1

Use showerror(this); instead of showerror($(this)) because you are wrapping the DOM element into a jquery object twice.

answered Nov 10, 2013 at 20:49

Lim H.

10.1k9 gold badges51 silver badges76 bronze badges

1 Comment

Contention Over a year ago

Yep, see the fiddle from @abhiklpm below. I must have something else going on although I'm not getting any js errors or conflicts. Thx.

Collectives™ on Stack Overflow

Adding class to jQuery object that has been passed to a function

2 Answers 2

8 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

1 Comment

Related