C# - Should Streams always be Closed, even if they didn't open properly?

Question

If i make a Stream object to open a text file with OpenFileDialog, in what scope should i close it? In the same scope were i declared it, or inside one of the ifs (to close it just in the case that it opened properly)?.

I leave you the code here so you can tell me...

Stream arch_Usuarios; OpenFileDialog openFileDialog_arch_Usuarios = new OpenFileDialog(); if (openFileDialog_arch_Usuarios.ShowDialog() == DialogResult.OK) { if ((arch_Usuarios = openFileDialog_arch_Usuarios.OpenFile()) != null) { ... } }

Greetings.

Look into using statement. That should solve this problem. — jnovacho
– jnovacho, Commented Nov 15, 2013 at 13:42
If a stream doesn't open properly, you won't get null or an uninitialized stream, but an exception. — CodeCaster
– CodeCaster, Commented Nov 15, 2013 at 13:44
Side note: Use .net naming conversions. refrain using Abc_Def style — Sriram Sakthivel
– Sriram Sakthivel, Commented Nov 15, 2013 at 13:44

Tim Coker · Accepted Answer · 2013-11-15 13:49:15Z

6

If you put those resources in a using statement, you won't have to worry about it. These objects are automatically cleaned up when they go out of scope, regardless of how the code exits, meaning even in the event that exception is thrown.

using(OpenFileDialog openFileDialog_arch_Usuarios = new OpenFileDialog()) { if (openFileDialog_arch_Usuarios.ShowDialog() == DialogResult.OK) { using(Stream arch_Usuarios = openFileDialog_arch_Usuarios.OpenFile()) { ... } } }

And here's my one pet peeve with using statements. You wind up with ridiculously indented code. Minor complaint, but still annoys me.

edited Nov 15, 2013 at 13:49

answered Nov 15, 2013 at 13:42

Tim Coker

6,5242 gold badges34 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Sriram Sakthivel Over a year ago

You need to use OpenFileDialog in using statement as well

Tim Coker Over a year ago

True. They could all go in using statements. The one thing I don't like about using statements (and this is minor) is the indentation that results. I tend to use them sparingly for that reason.

musefan Over a year ago

@SriramSakthivel: I don't think the dialog needs to go in a using, only the stream

Sriram Sakthivel Over a year ago

@musefan Why? OpenFileDialog uses unmanaged system resource, which has to be disposed.

Tim Coker Over a year ago

It could be argued either way. For readability, I prefer to use them sparingly. @musefan, the file dialog will be disposed when it goes out of scope.

|

Collectives™ on Stack Overflow

C# - Should Streams always be Closed, even if they didn't open properly?

1 Answer 1

7 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Related