getElementById doesn't return what it should

Question

I am trying to show which users have AdBlock and pass this information to Piwik but it seems to fail. It just shows like everyone got AdBlock enabled..

Here is the code I am using:

function _abpde() { if (document.getElementById("AdDiv")==null || document.getElementById("AdDiv").offsetHeight<=0) { _paq.push(['setCustomVariable',1,"AdBlock","Enabled","page"]); } else { _paq.push(['setCustomVariable',1,"AdBlock","Disabled","page"]); } } window.onload=_abpde();

And I am ussing the div:

<div class="AdDiv" id="AdDiv"> asd</div>

Any ideas what I am doing wrong? Thanks!

PS: When I try to remove the document.getElementById("AdDiv")==null the whole script fails and it doesn't even count visits..

xdazz · Accepted Answer · 2014-04-25 09:38:55Z

3

window.onload=_abpde();

should be

window.onload=_abpde;

() makes the function execute immediately.

answered Apr 25, 2014 at 9:38

xdazz

161k38 gold badges255 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3465843 Over a year ago

Ah thank you mate! That did solve a few problems, it still doesn't count users as it should though but that is another problem :P

Collectives™ on Stack Overflow

getElementById doesn't return what it should

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related